e0b880c REVIEW — heartwood

Radicle Heartwood Protocol & Stack

REVIEW

✓ CI success Lorenz Leutgeb committed 9 months ago

commit e0b880cc28ac790295e2470b220cb3cd1a9c5f2c
parent 7ed294c98b0a58760a303c5570098eaf3bd79c0f

1 passed (1 total) View logs

1 file changed +9 -13

modified crates/radicle/src/git.rs

@@ -598,19 +598,15 @@ pub fn configure_repository(repo: &git2::Repository) -> Result<(), git2::Error>

 ///   fetch = +refs/tags/*:refs/remotes/<name>/tags/*
 ///   tagOpt = --no-tags
 ///   pruneTags = false
 ///     ```
 ///
 /// Because of the `refs/tags/*` refspec, we have to set two options:
 ///   * `pruneTags = false`, and
 ///   * `tagOpt = --no-tags`
 ///
 /// The `pruneTags` is to ensure that `git` does not delete tags because the
 /// remote has them. Tags for a Radicle repository are synthesised by canonical
 /// refs and thus, the `rad` remote will handle fetching them.
 /// ```
 ///
 /// The `tagOpt` is to ensure that we do not fetch the tags from the remote and
 /// put them under `refs/tags`, again, because these are fetched by the `rad`
 /// remote.
 /// Because of the `+refs/tags/*:…` refspec, set:
 ///  1. `pruneTags = false` to ensure that `git` does not delete tags because
 ///     the remote does not have them. Tags for a Radicle repository are
 ///     synthesised by canonical refs and thus, the `rad` remote will handle
 ///     fetching them.
 ///  2. `tagOpt = --no-tags` to ensure that tags are not fetched and stored
 ///     under `refs/tags`, again, because these are fetched by the `rad` remote.
 pub fn configure_remote<'r>(
     repo: &'r git2::Repository,
     name: &str,

@@ -628,8 +624,8 @@ pub fn configure_remote<'r>(

     if name != (*rad::REMOTE_NAME).as_str() {
         let mut config = repo.config()?;
         config.set_str(&format!("remote.{name}.tagOpt"), "--no-tags")?;
         config.set_bool(&format!("remote.{name}.pruneTags"), false)?;
         config.set_str(&format!("remote.{name}.tagOpt"), "--no-tags")?;
     }
     if push != fetch {