9f62a82 radicle: Fix `cob::common::Title::new` — heartwood

Radicle Heartwood Protocol & Stack

radicle: Fix `cob::common::Title::new`

Defelo committed 7 months ago

commit 9f62a82b0bf277ce06b51821d6692bba998201a5
parent 5fea9ac05c7296dce3f8dec363b7442bec929c55

1 file changed +17 -4

modified crates/radicle/src/cob/common.rs

@@ -43,7 +43,7 @@ impl Deref for Timestamp {

     }
 }
 #[derive(Error, Debug)]
 #[derive(Error, Debug, PartialEq, Eq)]
 pub enum TitleError {
     #[error("empty title")]
     EmptyTitle,

@@ -70,11 +70,14 @@ impl Title {

     /// characters
     pub fn new(title: &str) -> Result<Self, TitleError> {
         if title.contains('\n') || title.contains('\r') {
             Err(TitleError::InvalidTitle)
         } else if title.is_empty() {
             return Err(TitleError::InvalidTitle);
         }
         let title = title.trim();
         if title.is_empty() {
             Err(TitleError::EmptyTitle)
         } else {
             Ok(Self(title.trim().to_string()))
             Ok(Self(title.into()))
         }
     }
 }

@@ -494,6 +497,16 @@ mod test {

     use super::*;
     #[test]
     fn test_title() {
         assert_eq!(Title::new(""), Err(TitleError::EmptyTitle));
         assert_eq!(Title::new(" "), Err(TitleError::EmptyTitle));
         assert_eq!(Title::new("\t"), Err(TitleError::EmptyTitle));
         assert_eq!(Title::new("foo\nbar"), Err(TitleError::InvalidTitle));
         assert_eq!(Title::new("foobar\n"), Err(TitleError::InvalidTitle));
         assert_eq!(Title::new(" valid title ").unwrap().0, "valid title");
     }
     #[test]
     fn test_color() {
         let c = Color::from_str("#ffccaa").unwrap();
         assert_eq!(c.to_string(), "#ffccaa".to_owned());