8c9966b cli/patch/review: Obsoletion Warning — heartwood

Radicle Heartwood Protocol & Stack

cli/patch/review: Obsoletion Warning

✗ CI failure Lorenz Leutgeb committed 7 months ago

commit 8c9966b9d97d93131e766828b9d1ecff7d561afb
parent e1dbd0b31b039fe8388d1056afcbd7138cc67ff5

2 failed (2 total) View logs

2 files changed +5 -0

modified CHANGELOG.md

@@ -13,6 +13,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

 - The option `rad self --nid` was deprecated in favor of `rad status --only nid`
 - `rad diff` was deprecated in favor of using `git diff`
 - `rad patch review --patch` and `rad patch review --delete` are made obsolete.
   This functionality never worked as intended, and may be removed before the
   next major release.
 ## New Features

modified crates/radicle-cli/src/commands/patch/review.rs

@@ -83,6 +83,7 @@ pub fn run(

             unified,
             hunk,
         } if by_hunk => {
             crate::warning::obsolete("rad patch review --patch");
             let mut opts = git::raw::DiffOptions::new();
             opts.patience(true)
                 .minimal(true)

@@ -124,6 +125,7 @@ pub fn run(

             }
         }
         Operation::Delete => {
             crate::warning::obsolete("rad patch review --delete");
             let name = git::refs::storage::draft::review(profile.id(), &patch_id);
             match repository.backend.find_reference(&name) {