Radish alpha
h
heartwood
Radicle Heartwood Protocol & Stack
Radicle
Git (anonymous pull)
Log in to clone via SSH
Commits ›
remote-helper: Prevent doubly verifying each push
✗ CI failure Lorenz Leutgeb committed 7 months ago
commit 88af09b7029887ffec5357c457ae0cbe0b4f0d02
parent 9c8905f829d62a2d269e5f0fdb309273bc9ecc62
1 failed (1 total) View logs
1 file changed +12 -2
modified crates/radicle-remote-helper/src/push.rs
@@ -881,8 +881,18 @@ fn push_ref(
    // This happens during the `list for-push` phase.

    let refspec = git::Refspec { src, dst, force };

    let repo = working.workdir().unwrap_or_else(|| working.path());
-
- 
    let mut args = vec!["push".to_string()];
+
+ 
    let mut args = vec![
+ 
        "push".to_string(),
+ 
        // This push is "internal" from the point of view of the user.
+ 
        // If they want to run a pre-push hook, then they would configure
+ 
        // this on their remote, and the hook would run before we get here.
+ 
        // However, the context of this invocation of `git push` is
+ 
        // the same repository, so if the user has configured a pre-push
+ 
        // hook it would run twice, which is not what we want, so set this
+ 
        // option.
+ 
        "--no-verify".to_string(),
+ 
    ];



    let verbosity: git::Verbosity = verbosity.into();

    args.extend(verbosity.into_flag());