836ae3b node: Warn about useless `--log-format` args — heartwood

Radicle Heartwood Protocol & Stack

node: Warn about useless `--log-format` args

✗ CI failure Lorenz Leutgeb committed 7 months ago

commit 836ae3b5c400b757c687799928703eb38211c893
parent dde08e35d09993abb11a14ae343af54ee077b8a7

1 passed 1 failed (2 total) View logs

1 file changed +15 -0

modified crates/radicle-node/src/main.rs

@@ -296,6 +296,21 @@ fn initialize_logging(options: &LogOptions) -> Result<(), Box<dyn std::error::Er

     log::set_boxed_logger(logger).expect("no other logger should have been set already");
     log::set_max_level(level.to_level_filter());
     // Now that we have a logger, and since this `fn` is the place to
     // interpret [`LogOptions`], warn about these options as appropriate.
     match (&options.logger, &options.format) {
         (_, None) => {
             // `--log-format` was not passed.
         }
         #[cfg(feature = "structured-logger")]
         (Logger::Structured, Some(LogFormat::Json)) => {
             // This logger consumes and interprets the format.
         }
         (_, Some(_)) => {
             log::warn!("Option `--log-format` has no effect on this logger.")
         }
     }
     Ok(())
 }