649fd80 radicle/crefs/rules: Exact patterns for branches — heartwood

Radicle Heartwood Protocol & Stack

radicle/crefs/rules: Exact patterns for branches

Lorenz Leutgeb committed 7 months ago

commit 649fd8023c3f385818a4bc76c00c2350efd20726
parent 0c869633201eaf55a77bd0d3f81d7bc89f6e30ae

2 files changed +8 -3

modified crates/radicle/src/git/canonical/rules.rs

@@ -81,6 +81,13 @@ impl<'a> TryFrom<Qualified<'a>> for Pattern {

 }
 impl Pattern {
     /// Construct a [`Pattern`] that matches a branch exactly.
     ///
     /// The resulting [`Pattern`] will match `refs/heads/<name>`.
     pub fn refs_heads_exact(name: &git::RefStr) -> Self {
         Self(QualifiedPattern::from(git::refs::branch(name)))
     }
     /// Check if the `refname` matches the rule's `refspec`.
     pub fn matches(&self, refname: &Qualified) -> bool {
         // N.b. Git's refspecs do not quite match with glob-star semantics. A

modified crates/radicle/src/identity/doc.rs

@@ -81,8 +81,6 @@ impl DocError {

 #[derive(Debug, Error)]
 pub enum DefaultBranchRuleError {
     #[error("could not create rule due to the reference name being invalid: {0}")]
     Pattern(#[from] rules::PatternError),
     #[error("could not load `xyz.radicle.project` to get default branch name: {0}")]
     Payload(#[from] PayloadError),
 }

@@ -751,7 +749,7 @@ impl Doc {

     pub fn default_branch_rule(
         &self,
     ) -> Result<(rules::Pattern, rules::ValidRule), DefaultBranchRuleError> {
         let pattern = rules::Pattern::try_from(self.default_branch()?.to_owned())?;
         let pattern = rules::Pattern::refs_heads_exact(self.project()?.default_branch());
         let rule = rules::Rule::new(
             rules::ResolvedDelegates::Delegates(self.delegates.clone()),
             self.threshold,