Radish alpha
h
Radicle Heartwood Protocol & Stack
Radicle
Git (anonymous pull)
Log in to clone via SSH
fetch: clean up logging
Fintan Halpenny committed 3 months ago
commit 3fae9084933969cfe68cae7aa17063da201f2df8
parent 02318f199c6f29a2eede1f282e1f9b99927d27ec
4 files changed +9 -13
modified crates/radicle-fetch/src/lib.rs
@@ -155,11 +155,7 @@ fn handle_handshake_err(err: handshake::Error) -> HandshakeError {
            gix_transport::client::Error::Io(error) => HandshakeError::Io(error),
            err => HandshakeError::Gix(handshake::Error::Transport(err)),
        },
-
        err => {
-
            log::warn!(target: "fetch", "Failed to perform handshake: {err}");
-
            HandshakeError::Gix(err)
-
        }
+
        err => HandshakeError::Gix(err),
    };
-
    log::warn!(target: "fetch", "{err}");
    err
}
modified crates/radicle-fetch/src/policy.rs
@@ -20,7 +20,7 @@ impl Allowed {
            .map_err(|err| error::Policy::FailedPolicy { rid, err })?;
        match entry.policy {
            SeedingPolicy::Block => {
-
                log::error!(target: "fetch", "Attempted to fetch non-seeded repo {rid}");
+
                log::info!(target: "fetch", "Attempted to fetch non-seeded repo {rid}");
                Err(error::Policy::BlockedPolicy { rid })
            }
            SeedingPolicy::Allow { scope: Scope::All } => Ok(Self::All),
@@ -37,7 +37,7 @@ impl Allowed {
                    let node = match node {
                        Ok(policy) => policy,
                        Err(err) => {
-
                            log::error!(target: "fetch", "Failed to read follow policy for {rid}: {err}");
+
                            log::debug!(target: "fetch", "Failed to read follow policy for {rid}: {err}");
                            continue;
                        }
                    };
@@ -81,7 +81,7 @@ impl BlockList {
            let entry = match entry {
                Ok(entry) => entry,
                Err(err) => {
-
                    log::error!(target: "fetch", "Failed to read follow policy: {err}");
+
                    log::debug!(target: "fetch", "Failed to read follow policy: {err}");
                    continue;
                }
            };
modified crates/radicle-fetch/src/state.rs
@@ -443,7 +443,7 @@ impl FetchState {
        match handle.transport.done() {
            Ok(()) => log::debug!(target: "fetch", "Sent done signal to remote {remote}"),
            Err(err) => {
-
                log::warn!(target: "fetch", "Attempted to send done to remote {remote}: {err}")
+
                log::debug!(target: "fetch", "Failed to signal EOF to {remote}: {err}")
            }
        }

@@ -485,7 +485,7 @@ impl FetchState {
                    self.prune(&remote);
                }
                sigrefs::DelegateStatus::Delegate { remote, data: None } => {
-
                    log::warn!(target: "fetch", "Pruning delegate {remote} tips, missing 'rad/sigrefs'");
+
                    log::debug!(target: "fetch", "Pruning delegate {remote} tips, missing 'rad/sigrefs'");
                    failures.push(sigrefs::Validation::MissingRadSigRefs(remote));
                    self.prune(&remote);
                    // This delegate has removed their `rad/sigrefs`.
@@ -552,7 +552,7 @@ impl FetchState {
                    let mut fails =
                        sigrefs::validate(&cache, sigrefs)?.unwrap_or(Validations::default());
                    if !fails.is_empty() {
-
                        log::warn!(target: "fetch", "Pruning delegate {remote} tips, due to validation failures");
+
                        log::debug!(target: "fetch", "Pruning delegate {remote} tips, due to validation failures");
                        self.prune(&remote);
                        valid_delegates.remove(&remote);
                        failed_delegates.insert(remote);
modified crates/radicle-fetch/src/transport.rs
@@ -328,8 +328,8 @@ fn agent_name() -> String {
        Ok(version) => version,
        Err(err) => {
            use radicle::git::VERSION_REQUIRED;
-
            log::warn!(target: "fetch", "The git version could not be determined: {err}");
-
            log::warn!(target: "fetch", "Pretending that we are on git version {VERSION_REQUIRED}.");
+
            log::debug!(target: "fetch", "The git version could not be determined: {err}");
+
            log::debug!(target: "fetch", "Pretending that we are on git version {VERSION_REQUIRED}.");
            VERSION_REQUIRED
        }
    };