244e300 cli: add user warning for implicitly set seeding policy scope — heartwood

Radicle Heartwood Protocol & Stack

cli: add user warning for implicitly set seeding policy scope

Adrian Duke committed 2 months ago

commit 244e3008bcb9c4a587ed6de702544aa43621592c
parent 77f2db8d637ca4e62fd3a61857a6d3ea2c1f52c3

3 files changed +33 -9

modified crates/radicle-cli/src/commands/debug.rs

@@ -131,7 +131,7 @@ fn stderr_of(bin: &str, args: &[&str]) -> anyhow::Result<String> {

 fn collect_warnings(profile: Option<&Profile>) -> Vec<String> {
     match profile {
         Some(profile) => crate::warning::nodes_renamed(&profile.config),
         Some(profile) => crate::warning::config_warnings(&profile.config),
         None => vec!["No Radicle profile found.".to_string()],
     }
 }

modified crates/radicle-cli/src/commands/node/control.rs

@@ -257,7 +257,7 @@ pub fn connect_many(

 }
 pub fn status(node: &Node, profile: &Profile) -> anyhow::Result<()> {
     for warning in crate::warning::nodes_renamed(&profile.config) {
     for warning in crate::warning::config_warnings(&profile.config) {
         term::warning(warning);
     }

modified crates/radicle-cli/src/warning.rs

@@ -22,26 +22,50 @@ fn nodes_renamed_for_option(

     option: &'static str,
     iter: impl IntoIterator<Item = ConnectAddress>,
 ) -> Vec<String> {
     let mut warnings: Vec<String> = vec![];
     for (i, value) in iter.into_iter().enumerate() {
     iter.into_iter().enumerate().fold(Vec::new(), |mut warnings, (i, value)| {
         let old: Address = value.into();
         if let Some(new) = NODES_RENAMED.get(&old) {
             warnings.push(format!(
                 "Value of configuration option `{option}` at index {i} mentions node with address '{old}', which has been renamed to '{new}'. Please update your configuration."
             ));
         }
     }
     warnings
         warnings
     })
 }
 pub(crate) fn nodes_renamed(config: &Config) -> Vec<String> {
 fn nodes_renamed(config: &Config) -> Vec<String> {
     let mut warnings = nodes_renamed_for_option("node.connect", config.node.connect.clone());
     warnings.extend(nodes_renamed_for_option(
         "preferredSeeds",
         config.preferred_seeds.clone(),
     ));
     warnings
 }
 fn implicit_seeding_policy_allow_scope(config: &Config) -> Vec<String> {
     use radicle::node::config::DefaultSeedingPolicy;
     use radicle::node::policy;
     let DefaultSeedingPolicy::Allow { scope } = config.node.seeding_policy else {
         return vec![];
     };
     if scope.is_implicit() {
         let scope = scope.into_inner();
         vec![format!(
                 "node 'seedingPolicy.scope' has been set to '{scope}' by default. This default value will be removed in a future release. Please explicitly set it to one of ['{}', '{}'] in your node config.",
                 policy::Scope::All,
                 policy::Scope::Followed,
             )]
     } else {
         vec![]
     }
 }
 pub(crate) fn config_warnings(config: &Config) -> Vec<String> {
     let mut warnings = nodes_renamed(config);
     warnings.extend(implicit_seeding_policy_allow_scope(config));
     warnings
 }