240ddcb use `CONIN$` instead of `/dev/tty` on windows — heartwood

Radicle Heartwood Protocol & Stack

use `CONIN$` instead of `/dev/tty` on windows

✗ CI failure justarandomgeek committed 1 month ago

commit 240ddcb15d66e6cbb708594149ab3cf06cc7f973
parent 7bac17146c40b32b2ce0e27b96a555a44f3ef2ba

1 failed (1 total) View logs

2 files changed +7 -0

modified CHANGELOG.md

@@ -46,6 +46,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

   indistinguishable from `[::1]:8776`. Since a port number is always required
   along a host when providing an address, IPv6 addresses now always require
   brackets to avoid confusion.
 - On Windows, use `CONIN$` to reopen the terminal input stream, instead of refusing
   to launch an editor for `radicle-remote-helper`
 ## Deprecations

modified crates/radicle-term/src/editor.rs

@@ -162,6 +162,11 @@ impl Editor {

                 .write(true)
                 .open("/dev/tty")?;
             process::Stdio::from(tty)
         } else if cfg!(windows) {
             let tty = fs::OpenOptions::new()
                 .read(true)
                 .open("CONIN$")?;
             process::Stdio::from(tty)
         } else {
             return Err(io::Error::new(
                 io::ErrorKind::Unsupported,