Radish alpha
h
Radicle Heartwood Protocol & Stack
Radicle
Git (anonymous pull)
Log in to clone via SSH
REVIEW: Do not return `BrokenPipe` from external COB invocation
Lorenz Leutgeb committed 24 days ago
commit 12901cdd129aa436ec65aa0e124547bfc09d630e
parent ad87939cf352f8ea0b52983948608d183d32376f
1 file changed +3 -8
modified crates/radicle/src/cob/external.rs
@@ -81,7 +81,7 @@
//! [remote helpers]: https://git-scm.com/docs/gitremote-helpers

use std::collections::HashMap;
-
use std::io::{Error as IoError, ErrorKind};
+
use std::io::Error as IoError;
use std::process::{Command, Stdio};

use serde::{Deserialize, Serialize};
@@ -158,17 +158,12 @@ impl External {
            prefix + suffix
        };

-
        let child = Command::new(command_name)
+
        let mut child = Command::new(command_name)
            .stdin(Stdio::piped())
            .stdout(Stdio::piped())
            .spawn()?;

-
        let Some(stdin) = &child.stdin else {
-
            return Err(Error::Io(IoError::new(
-
                ErrorKind::BrokenPipe,
-
                "stdin not available",
-
            )));
-
        };
+
        let stdin = child.stdin.take().expect("handle preset");

        #[derive(Serialize)]
        struct OpMessage {