0c24941 radicle/sigrefs: Revert strict verification of `refs/rad/root` — heartwood

Radicle Heartwood Protocol & Stack

radicle/sigrefs: Revert strict verification of `refs/rad/root`

◌ CI pending Lorenz Leutgeb committed 2 months ago

commit 0c24941ba7c5e0989e467e8c58bb8470f66db962
parent c237a3fe479050691001ad7487c6ec151dbb797b

1 pending (1 total) View logs

2 files changed +10 -2

modified crates/radicle/src/storage/refs/sigrefs/read.rs

@@ -258,10 +258,17 @@ impl Commit {

                 // Identity verification succeeds.
             }
         } else {
             return Err(error::Verify::MissingIdentity(error::MissingIdentity {
             let err = error::Verify::MissingIdentity(error::MissingIdentity {
                 sigrefs_commit: self.oid,
                 expected,
             }));
             });
             log::debug!("Reading sigrefs will error in the future: {err}");
             // TODO: Make this return the error
             // and enable test `test::commit_reader::missing_identity`.
             // Identity verification succeeds.
         }
         self.refs.remove_sigrefs();

modified crates/radicle/src/storage/refs/sigrefs/read/test/commit_reader.rs

@@ -73,6 +73,7 @@ fn missing_commit() {

 }
 #[test]
 #[ignore = "strict verification of `refs/rad/root` reverted due to compatibility issues"]
 fn missing_identity() {
     let head = mock::oid(1);
     let refs = [(mock::refs_heads_main(), mock::oid(10))];