Radish alpha
h
Radicle Heartwood Protocol & Stack
Radicle
Git (anonymous pull)
Log in to clone via SSH
cob: Fix compatibility with certain old patches
cloudhead committed 1 year ago
commit 0bb0fe8f258194cae4bc4177c36f177f20c2d467
parent 6dcfbfcdee6df013656b13afac3c765ee314d129
1 file changed +3 -3
modified radicle/src/cob/patch.rs
@@ -864,9 +864,6 @@ impl Patch {
                    // If the revision was redacted concurrently, there's nothing to do.
                    return Ok(());
                };
-
                if summary.is_none() && verdict.is_none() {
-
                    return Err(Error::EmptyReview);
-
                }
                if let Some(rev) = rev {
                    // Insert a review if there isn't already one. Otherwise we just ignore
                    // this operation
@@ -2173,6 +2170,9 @@ where
        labels: Vec<Label>,
        signer: &G,
    ) -> Result<ReviewId, Error> {
+
        if verdict.is_none() && summary.is_none() {
+
            return Err(Error::EmptyReview);
+
        }
        self.transaction("Review", signer, |tx| {
            tx.review(revision, verdict, summary, labels)
        })