054655d node: Log read buffer if not empty — heartwood

Radicle Heartwood Protocol & Stack

node: Log read buffer if not empty

Alexis Sellier committed 3 years ago

commit 054655d79b822ebeb5ab78ec506c59cb82a5271d
parent f66ecd4ece5b48ffbe4481aa905a43ad35b6a2a4

1 file changed +15 -3

modified radicle-node/src/wire/protocol.rs

@@ -26,6 +26,7 @@ use radicle::storage::WriteStorage;

 use crate::crypto::Signer;
 use crate::service::reactor::{Fetch, Io};
 use crate::service::{routing, session, DisconnectReason, Message, Service};
 use crate::wire;
 use crate::wire::{Decode, Encode};
 use crate::worker::{Task, TaskResult};
 use crate::Link;

@@ -479,11 +480,22 @@ where

                                 // Buffer is empty, or message isn't complete.
                                 break;
                             }
                             Err(err) => {
                                 // TODO(cloudhead): Include error in reason.
                                 log::error!(target: "wire", "Invalid message from {}: {err}", id);
                             Err(e) => {
                                 log::error!(target: "wire", "Invalid message from {id}: {e}");
                                 let mut leftover = if let wire::Error::UnknownMessageType(ty) = e {
                                     ty.to_ne_bytes().to_vec()
                                 } else {
                                     vec![]
                                 };
                                 leftover.extend(self.read_queue.drain(..));
                                 if !leftover.is_empty() {
                                     log::debug!(target: "wire", "Dropping read buffer with `{:?}`", &leftover);
                                 }
                                 self.disconnect(
                                     fd,
                                     // TODO(cloudhead): Include error in reason.
                                     DisconnectReason::Session(session::Error::Misbehavior),
                                 );
                                 break;