c9bad8d Fix memory/fd leak with pkg repo signing_command — HardenedBSD-pkg

rad:z3QDZAW2FAfuLvihrhiyDC9fAD8G9

HardenedBSD Package Manager

Fix memory/fd leak with pkg repo signing_command

Bryan Drewery committed 12 years ago

commit c9bad8de0b5632fb2fbede1a15e45d1210ffe75a
parent aec69ab

1 file changed +5 -1

modified libpkg/pkg_repo.c

@@ -438,7 +438,7 @@ cmd_sign(char *path, char **argv, int argc, struct sbuf **sig, struct sbuf **cer

 {
 	FILE *fp;
 	char sha256[SHA256_DIGEST_LENGTH * 2 + 1];
 	struct sbuf *cmd;
 	struct sbuf *cmd = NULL;
 	struct sbuf *buf = NULL;
 	char *line = NULL;
 	size_t linecap = 0;

@@ -492,6 +492,10 @@ cmd_sign(char *path, char **argv, int argc, struct sbuf **sig, struct sbuf **cer

 	sbuf_finish(*sig);
 	sbuf_finish(*cert);
 	if (cmd)
 		sbuf_delete(cmd);
 	pclose(fp);
 	return (EPKG_OK);
 }