Radish alpha
H
HardenedBSD-pkg
rad:z3QDZAW2FAfuLvihrhiyDC9fAD8G9
HardenedBSD Package Manager
Radicle
Git
Commits › b83b113
Bug #984: Addition of a semantic patch file for showing unnecessary checks before a few known functions
Markus Elfring committed 11 years ago
commit b83b113da4f1f79fbc687395c26a88ad5a8f6463
parent 420162f
1 file changed +121 -0
added tests/cocci/delete_if1.cocci
@@ -0,0 +1,121 @@
+ 
@Remove_unnecessary_pointer_checks1@
+ 
expression x;
+ 
identifier release =~ "^(?x)
+ 
(?:(?:(?:pkg(?:db_(?:sqlite_)?it
+ 
            |  _(?:audit
+ 
                |  conflict
+ 
                |  deb
+ 
                |  file
+ 
                |  manifest_keys
+ 
                |  option
+ 
                |  provide
+ 
                |  repo_binary_update_item
+ 
                |  shlib
+ 
                )
+ 
            )?
+ 
      | rsa
+ 
      | sbuf
+ 
      )_)?free
+ 
| free_(?:file_attr|percent_esc)
+ 
| load_repositories
+ 
| pkg(?:_reset
+ 
     |  db_(?:close|sqlite_it_reset)
+ 
     )
+ 
| sbuf_(?:delete|reset)
+ 
)$";
+ 
@@
+ 
-if (\(x != 0 \| x != NULL\))
+ 
    release(x);
+
+ 
@Remove_unnecessary_pointer_checks2@
+ 
expression x;
+ 
identifier release =~ "^(?x)
+ 
(?:(?:(?:pkg(?:db_(?:sqlite_)?it
+ 
            |  _(?:audit
+ 
                |  conflict
+ 
                |  deb
+ 
                |  file
+ 
                |  manifest_keys
+ 
                |  option
+ 
                |  provide
+ 
                |  repo_binary_update_item
+ 
                |  shlib
+ 
                )
+ 
            )?
+ 
      | rsa
+ 
      | sbuf
+ 
      )_)?free
+ 
| free_(?:file_attr|percent_esc)
+ 
| load_repositories
+ 
| pkg(?:_reset
+ 
     |  db_(?:close|sqlite_it_reset)
+ 
     )
+ 
| sbuf_(?:delete|reset)
+ 
)$";
+ 
@@
+ 
-if (\(x != 0 \| x != NULL\)) {
+ 
    release(x);
+ 
    x = \(0 \| NULL\);
+ 
-}
+
+ 
@Remove_unnecessary_pointer_checks3@
+ 
expression a, b;
+ 
identifier release =~ "^(?x)
+ 
(?:(?:(?:pkg(?:db_(?:sqlite_)?it
+ 
            |  _(?:audit
+ 
                |  conflict
+ 
                |  deb
+ 
                |  file
+ 
                |  manifest_keys
+ 
                |  option
+ 
                |  provide
+ 
                |  repo_binary_update_item
+ 
                |  shlib
+ 
                )
+ 
            )?
+ 
      | rsa
+ 
      | sbuf
+ 
      )_)?free
+ 
| free_(?:file_attr|percent_esc)
+ 
| load_repositories
+ 
| pkg(?:_reset
+ 
     |  db_(?:close|sqlite_it_reset)
+ 
     )
+ 
| sbuf_(?:delete|reset)
+ 
)$";
+ 
@@
+ 
-if (\(a != 0 \| a != NULL\) && \(b != 0 \| b != NULL\))
+ 
+if (a)
+ 
    release(b);
+
+ 
@Remove_unnecessary_pointer_checks4@
+ 
expression a, b;
+ 
identifier release =~ "^(?x)
+ 
(?:(?:(?:pkg(?:db_(?:sqlite_)?it
+ 
            |  _(?:audit
+ 
                |  conflict
+ 
                |  deb
+ 
                |  file
+ 
                |  manifest_keys
+ 
                |  option
+ 
                |  provide
+ 
                |  repo_binary_update_item
+ 
                |  shlib
+ 
                )
+ 
            )?
+ 
      | rsa
+ 
      | sbuf
+ 
      )_)?free
+ 
| free_(?:file_attr|percent_esc)
+ 
| load_repositories
+ 
| pkg(?:_reset
+ 
     |  db_(?:close|sqlite_it_reset)
+ 
     )
+ 
| sbuf_(?:delete|reset)
+ 
)$";
+ 
@@
+ 
-if (\(a != 0 \| a != NULL\) && \(b != 0 \| b != NULL\)) {
+ 
+if (a) {
+ 
    release(b);
+ 
    b = \(0 \| NULL\);
+ 
 }