8c12350 Speed up pkg delete by removing useless where clause and not scanning the dependency table — HardenedBSD-pkg

rad:z3QDZAW2FAfuLvihrhiyDC9fAD8G9

HardenedBSD Package Manager

Speed up pkg delete by removing useless where clause and not scanning the dependency table

Baptiste Daroussin committed 14 years ago

commit 8c12350e915708301d852ca770fd472db42ce002
parent a575a56

1 file changed +2 -2

modified libpkg/pkgdb.c

@@ -2034,7 +2034,7 @@ pkgdb_query_delete(struct pkgdb *db, match_t match, int nbpkgs, char **pkgs, int

 		"ORDER BY weight ASC;";
 	sbuf_cat(sql, "INSERT OR IGNORE INTO delete_job (origin, pkgid) "
 			"SELECT p.origin, p.id FROM packages as p, deps as d WHERE p.origin = d.origin AND ");
 			"SELECT p.origin, p.id FROM packages as p WHERE ");
 	switch (match) {
 		case MATCH_ALL:

@@ -2061,7 +2061,7 @@ pkgdb_query_delete(struct pkgdb *db, match_t match, int nbpkgs, char **pkgs, int

 	sbuf_printf(sql, how, "p.name");
 	sbuf_cat(sql, " OR ");
 	sbuf_printf(sql, how, "p.origin" );
 	sbuf_printf(sql, how, "p.origin");
 	sbuf_cat(sql, " OR ");
 	sbuf_printf(sql, how, "p.name || \"-\" || p.version");