79f37e1 pkg_jobs: plug memory leaks in autoremove — HardenedBSD-pkg

rad:z3QDZAW2FAfuLvihrhiyDC9fAD8G9

HardenedBSD Package Manager

pkg_jobs: plug memory leaks in autoremove

Baptiste Daroussin committed 2 years ago

commit 79f37e1ac0b6fd227076fbc2a7fc6c392f84bc03
parent ce20618

1 file changed +4 -2

modified libpkg/pkg_jobs.c

@@ -715,7 +715,7 @@ static bool

 pkg_jobs_test_automatic(struct pkg_jobs *j, struct pkg *p)
 {
 	struct pkg_dep *d = NULL;
 	struct pkg *npkg;
 	struct pkg *npkg = NULL;
 	struct pkgdb_it *it;
 	while (pkg_rdeps(p, &d) == EPKG_OK) {

@@ -731,6 +731,7 @@ pkg_jobs_test_automatic(struct pkg_jobs *j, struct pkg *p)

 		while (pkgdb_it_next(it, &npkg, PKG_LOAD_BASIC) == EPKG_OK) {
 			if (!is_orphaned(j, npkg->uid)) {
 				pkgdb_it_free(it);
 				pkg_free(npkg);
 				return (false);
 			}
 		}

@@ -745,12 +746,13 @@ pkg_jobs_test_automatic(struct pkg_jobs *j, struct pkg *p)

 		while (pkgdb_it_next(it, &npkg, PKG_LOAD_BASIC) == EPKG_OK) {
 			if (!is_orphaned(j, npkg->uid)) {
 				pkgdb_it_free(it);
 				pkg_free(npkg);
 				return (false);
 			}
 		}
 		pkgdb_it_free(it);
 	}
 	pkg_free(npkg);
 	return (true);
 }