Radish alpha
H
HardenedBSD-pkg
rad:z3QDZAW2FAfuLvihrhiyDC9fAD8G9
HardenedBSD Package Manager
Radicle
Git
Commits › 721e2b0
cocci: updated some tests in order to avoid assert(3) and use pkg_emit_errno() instead.
Alexandre Perrin committed 10 years ago
commit 721e2b0881c53879c80b7007bf88613ac0f86e49
parent daaeec6
3 files changed +16 -10
modified tests/cocci/pkg/strlcat.cocci
@@ -9,4 +9,5 @@ expression E, E1, S;
@@



- strlcat(E, E1, S);
- 
+ assert(strlcat(E, E1, S) < S)/* FIXME: strlcat.cocci */;
+ 
+ if (strlcat(E, E1, S) >= S)
+ 
+ 	pkg_emit_errno("strlcat", TEXT(S));
modified tests/cocci/pkg/strlcpy.cocci
@@ -9,4 +9,5 @@ expression E, E1, S;
@@



- strlcpy(E, E1, S);
- 
+ assert(strlcpy(E, E1, S) < S)/* FIXME: strlcpy.cocci */;
+ 
+ if (strlcpy(E, E1, S) >= S)
+ 
+ 	pkg_emit_errno("strlcpy", TEXT(S));
modified tests/cocci/pkg/unchecked_malloc.cocci
@@ -12,8 +12,9 @@ local idexpression n;
expression E;

@@
- 
- n = malloc(E);
- 
+ assert(n = malloc(E)) /* FIXME: unchecked_malloc.cocci */;
+ 
n = malloc(E);
+ 
+ if (n == NULL)
+ 
+ 	pkg_emit_errno("malloc", TEXT(E));

... when != (n == NULL)

    when != (n != NULL)
@@ -22,8 +23,9 @@ local idexpression n;
expression E, E1;

@@
- 
- n = calloc(E, E1);
- 
+ assert(n = calloc(E, E1)) /* FIXME: unchecked_malloc.cocci */;
+ 
n = calloc(E, E1);
+ 
+ if (n == NULL)
+ 
+ 	pkg_emit_errno("calloc", TEXT2(E, E1));

... when != (n == NULL)

    when != (n != NULL)
@@ -32,8 +34,9 @@ local idexpression n;
expression E, E1;

@@
- 
- n = realloc(E, E1);
- 
+ assert(n = realloc(E, E1)) /* FIXME: unchecked_malloc.cocci */;
+ 
n = realloc(E, E1);
+ 
+ if (n == NULL)
+ 
+ 	pkg_emit_errno("realloc", TEXT2(E, E1));

... when != (n == NULL)

    when != (n != NULL)
@@ -42,7 +45,8 @@ local idexpression n;
expression E;

@@
- 
- n = strdup(E);
- 
+ assert(n = strdup(E)) /* FIXME: unchecked_malloc.cocci */;
+ 
 n = strdup(E);
+ 
+ if (n == NULL)
+ 
+ 	pkg_emit_errno("strdup", TEXT(E));

... when != (n == NULL)

    when != (n != NULL)