Radish alpha
H
HardenedBSD-pkg
rad:z3QDZAW2FAfuLvihrhiyDC9fAD8G9
HardenedBSD Package Manager
Radicle
Git
Commits › 1e87b6b
lua: cover all of the user facing functions with tests
Baptiste Daroussin committed 4 years ago
commit 1e87b6b4345d038e8619b7c2592a1294803b042c
parent 22db254
1 file changed +441 -8
modified tests/lib/lua.c
@@ -1,5 +1,5 @@
/*
- 
 * Copyright (c) 2021 Baptiste Daroussin <bapt@FreeBSD.org
+ 
 * Copyright (c) 2021 Baptiste Daroussin <bapt@FreeBSD.org>

 *

 * Redistribution and use in source and binary forms, with or without

 * modification, are permitted provided that the following conditions
@@ -32,12 +32,20 @@
#include <stdlib.h>



ATF_TC(readdir);
+ 
ATF_TC(stat);
+ 
ATF_TC(print_msg);
+ 
ATF_TC(execute);
+ 
ATF_TC(override);
+ 
ATF_TC(fileops);
+ 
ATF_TC(prefix_path);
- 
ATF_TC_HEAD(readdir, tc)
- 
{
- 
	atf_tc_set_md_var(tc, "descr", "Testing for lua functions");
-
- 
}
+ 
ATF_TC_HEAD(readdir, tc) { }
+ 
ATF_TC_HEAD(stat, tc) {}
+ 
ATF_TC_HEAD(print_msg, tc) {}
+ 
ATF_TC_HEAD(execute, tc) {}
+ 
ATF_TC_HEAD(override, tc) {}
+ 
ATF_TC_HEAD(fileops, tc) {}
+ 
ATF_TC_HEAD(prefix_path, tc) {}



ATF_TC_BODY(readdir, tc)

{
@@ -65,12 +73,21 @@ ATF_TC_BODY(readdir, tc)


	p = atf_utils_fork();

	if (p == 0) {
- 
		if (luaL_dostring(L, "if test.readdir(\".\") == nil then print(\"nil output\") end")) {
+ 
		if (luaL_dostring(L, "test.readdir()")) {

			printf("%s\n", lua_tostring(L, -1));

		}

		exit(lua_tonumber(L, -1));

	}
- 
	atf_utils_wait(p, 0, "", "");
+ 
	atf_utils_wait(p, 0, "[string \"test.readdir()\"]:1: bad argument #0 to 'readdir' (pkg.readdir takes exactly one argument)\n", "");
+
+ 
	p = atf_utils_fork();
+ 
	if (p == 0) {
+ 
		if (luaL_dostring(L, "res = test.readdir(\".\")\nif res ~= nil then print(#res) end")) {
+ 
			printf("%s\n", lua_tostring(L, -1));
+ 
		}
+ 
		exit(lua_tonumber(L, -1));
+ 
	}
+ 
	atf_utils_wait(p, 0, "2\n", "");

	p = atf_utils_fork();

	if (p == 0) {

		if (luaL_dostring(L, "if test.readdir(\"nonexistent\") ~= nil then print(\"non nil output\") end")) {
@@ -79,6 +96,7 @@ ATF_TC_BODY(readdir, tc)
		exit(lua_tonumber(L, -1));

	}

	atf_utils_wait(p, 0, "", "");
+ 


	p = atf_utils_fork();

	if (p == 0) {

		if (luaL_dostring(L, "if test.readdir(\"/\") ~= nil then print(\"nil output\") end")) {
@@ -87,11 +105,426 @@ ATF_TC_BODY(readdir, tc)
		exit(lua_tonumber(L, -1));

	}

	atf_utils_wait(p, 0, "", "");
+
+ 
	close(open("testfile", O_CREAT|O_TRUNC));
+ 
	p = atf_utils_fork();
+ 
	if (p == 0) {
+ 
		if (luaL_dostring(L, "if test.readdir(\"testfile\") ~= nil then print(\"nil output\") end")) {
+ 
			printf("%s\n", lua_tostring(L, -1));
+ 
		}
+ 
		exit(lua_tonumber(L, -1));
+ 
	}
+ 
	atf_utils_wait(p, 0, "", "");
+
+ 
	p = atf_utils_fork();
+ 
	if (p == 0) {
+ 
		if (luaL_dostring(L, "res = test.readdir(\".\")\n print(#res)")) {
+ 
			printf("%s\n", lua_tostring(L, -1));
+ 
		}
+ 
		exit(lua_tonumber(L, -1));
+ 
	}
+ 
	atf_utils_wait(p, 0, "3\n", "");
+ 
}
+
+ 
ATF_TC_BODY(stat, tc)
+ 
{
+ 
	int rootfd = open(getcwd(NULL, 0), O_DIRECTORY);
+ 
	lua_State *L = luaL_newstate();
+ 
	static const luaL_Reg test_lib[] = {
+ 
		{ "stat", lua_stat },
+ 
		{ NULL, NULL },
+ 
	};
+ 
	luaL_openlibs(L);
+ 
	lua_override_ios(L, false);
+ 
	luaL_newlib(L, test_lib);
+ 
	lua_setglobal(L, "test");
+ 
	lua_pushinteger(L, rootfd);
+ 
	lua_setglobal(L, "rootfd");
+
+ 
	pid_t p = atf_utils_fork();
+ 
	if (p == 0) {
+ 
		if (luaL_dostring(L, "test.stat(\".\", \"plop\")")) {
+ 
			printf("%s\n", lua_tostring(L, -1));
+ 
		}
+ 
		exit(lua_tonumber(L, -1));
+ 
	}
+ 
	atf_utils_wait(p, 0, "[string \"test.stat(\".\", \"plop\")\"]:1: bad argument #2 to 'stat' (pkg.stat takes exactly one argument)\n", "");
+
+ 
	p = atf_utils_fork();
+ 
	if (p == 0) {
+ 
		if (luaL_dostring(L, "test.stat()")) {
+ 
			printf("%s\n", lua_tostring(L, -1));
+ 
		}
+ 
		exit(lua_tonumber(L, -1));
+ 
	}
+ 
	atf_utils_wait(p, 0, "[string \"test.stat()\"]:1: bad argument #0 to 'stat' (pkg.stat takes exactly one argument)\n", "");
+
+ 
	p = atf_utils_fork();
+ 
	if (p == 0) {
+ 
		if (luaL_dostring(L, "st = test.stat(\".\")\nprint(st.type)")) {
+ 
			printf("%s\n", lua_tostring(L, -1));
+ 
		}
+ 
		exit(lua_tonumber(L, -1));
+ 
	}
+ 
	atf_utils_wait(p, 0, "dir\n", "");
+
+ 
	close(open("testfile", O_CREAT|O_TRUNC));
+ 
	p = atf_utils_fork();
+ 
	if (p == 0) {
+ 
		if (luaL_dostring(L, "st = test.stat(\"testfile\")\nprint(st.type)")) {
+ 
			printf("%s\n", lua_tostring(L, -1));
+ 
		}
+ 
		exit(lua_tonumber(L, -1));
+ 
	}
+ 
	atf_utils_wait(p, 0, "reg\n", "");
+
+ 
	symlink("testfile", "plop");
+ 
	p = atf_utils_fork();
+ 
	if (p == 0) {
+ 
		if (luaL_dostring(L, "st = test.stat(\"plop\")\nprint(st.type)")) {
+ 
			printf("%s\n", lua_tostring(L, -1));
+ 
		}
+ 
		exit(lua_tonumber(L, -1));
+ 
	}
+ 
	atf_utils_wait(p, 0, "lnk\n", "");
+
+ 
	lua_pushinteger(L, -1);
+ 
	lua_setglobal(L, "rootfd");
+ 
	p = atf_utils_fork();
+ 
	if (p == 0) {
+ 
		if (luaL_dostring(L, "st = test.stat(\".\")\nprint(st)")) {
+ 
			printf("%s\n", lua_tostring(L, -1));
+ 
		}
+ 
		exit(lua_tonumber(L, -1));
+ 
	}
+ 
	atf_utils_wait(p, 0, "nil\n", "");
+ 
}
+
+ 
ATF_TC_BODY(print_msg, tc)
+ 
{
+ 
	lua_State *L = luaL_newstate();
+ 
	static const luaL_Reg test_lib[] = {
+ 
		{ "print_msg", lua_print_msg },
+ 
		{ NULL, NULL },
+ 
	};
+ 
	int fd = open("testfile", O_CREAT|O_TRUNC);
+ 
	luaL_openlibs(L);
+ 
	lua_override_ios(L, false);
+ 
	luaL_newlib(L, test_lib);
+ 
	lua_setglobal(L, "test");
+ 
	lua_pushinteger(L, fd);
+ 
	lua_setglobal(L, "msgfd");
+
+ 
	pid_t p = atf_utils_fork();
+ 
	if (p == 0) {
+ 
		if (luaL_dostring(L, "test.print_msg()")) {
+ 
			printf("%s\n", lua_tostring(L, -1));
+ 
		}
+ 
		exit(lua_tonumber(L, -1));
+ 
	}
+ 
	atf_utils_wait(p, 0, "[string \"test.print_msg()\"]:1: bad argument #0 to 'print_msg' (pkg.print_msg takes exactly one argument)\n", "");
+
+ 
	p = atf_utils_fork();
+ 
	if (p == 0) {
+ 
		if (luaL_dostring(L, "test.print_msg(1, 2)")) {
+ 
			printf("%s\n", lua_tostring(L, -1));
+ 
		}
+ 
		exit(lua_tonumber(L, -1));
+ 
	}
+ 
	atf_utils_wait(p, 0, "[string \"test.print_msg(1, 2)\"]:1: bad argument #2 to 'print_msg' (pkg.print_msg takes exactly one argument)\n", "");
+
+ 
	p = atf_utils_fork();
+ 
	if (p == 0) {
+ 
		if (luaL_dostring(L, "test.print_msg(\"bla\")")) {
+ 
			printf("%s\n", lua_tostring(L, -1));
+ 
		}
+ 
		exit(lua_tonumber(L, -1));
+ 
	}
+ 
	atf_utils_wait(p, 0, "", "");
+ 
	close(fd);
+ 
	atf_utils_compare_file("testfile", "bla\n");
+ 
}
+
+ 
ATF_TC_BODY(execute, tc)
+ 
{
+ 
	lua_State *L = luaL_newstate();
+ 
	static const luaL_Reg test_lib[] = {
+ 
		{ "exec", lua_exec },
+ 
		{ NULL, NULL },
+ 
	};
+ 
	luaL_openlibs(L);
+ 
	lua_override_ios(L, false);
+ 
	luaL_newlib(L, test_lib);
+ 
	lua_setglobal(L, "test");
+
+ 
	pid_t p = atf_utils_fork();
+ 
	if (p == 0) {
+ 
		if (luaL_dostring(L, "test.exec()")) {
+ 
			printf("%s\n", lua_tostring(L, -1));
+ 
		}
+ 
		exit(lua_tonumber(L, -1));
+ 
	}
+ 
	atf_utils_wait(p, 0, "[string \"test.exec()\"]:1: bad argument #0 to 'exec' (pkg.exec takes exactly one argument)\n", "");
+
+ 
	p = atf_utils_fork();
+ 
	if (p == 0) {
+ 
		if (luaL_dostring(L, "test.exec(plop)")) {
+ 
			printf("%s\n", lua_tostring(L, -1));
+ 
		}
+ 
		exit(lua_tonumber(L, -1));
+ 
	}
+ 
	atf_utils_wait(p, 0, "[string \"test.exec(plop)\"]:1: bad argument #1 to 'exec' (table expected, got nil)\n", "");
+
+ 
	p = atf_utils_fork();
+ 
	if (p == 0) {
+ 
		if (luaL_dostring(L, "test.exec(plop, meh)")) {
+ 
			printf("%s\n", lua_tostring(L, -1));
+ 
		}
+ 
		exit(lua_tonumber(L, -1));
+ 
	}
+ 
	atf_utils_wait(p, 0, "[string \"test.exec(plop, meh)\"]:1: bad argument #2 to 'exec' (pkg.exec takes exactly one argument)\n", "");
+
+ 
	p = atf_utils_fork();
+ 
	if (p == 0) {
+ 
		if (luaL_dostring(L, "test.exec({\"/bin/echo\", \"1\"})")) {
+ 
			printf("%s\n", lua_tostring(L, -1));
+ 
		}
+ 
		exit(lua_tonumber(L, -1));
+ 
	}
+ 
	atf_utils_wait(p, 0, "1\n", "");
+ 
}
+
+ 
ATF_TC_BODY(override, tc)
+ 
{
+ 
	lua_State *L = luaL_newstate();
+ 
	luaL_openlibs(L);
+ 
	lua_override_ios(L, true);
+
+ 
	pid_t p = atf_utils_fork();
+ 
	if (p == 0) {
+ 
		if (luaL_dostring(L, "os.execute(\"/usr/bin/true\")")) {
+ 
			printf("%s\n", lua_tostring(L, -1));
+ 
		}
+ 
		exit(lua_tonumber(L, -1));
+ 
	}
+ 
	atf_utils_wait(p, 0, "[string \"os.execute(\"/usr/bin/true\")\"]:1: os.execute not available\n", "");
+
+ 
	p = atf_utils_fork();
+ 
	if (p == 0) {
+ 
		if (luaL_dostring(L, "os.exit(1)")) {
+ 
			printf("%s\n", lua_tostring(L, -1));
+ 
		}
+ 
		exit(lua_tonumber(L, -1));
+ 
	}
+ 
	atf_utils_wait(p, 0, "[string \"os.exit(1)\"]:1: os.exit not available\n", "");
+
+ 
	int rootfd = open(getcwd(NULL, 0), O_DIRECTORY);
+ 
	lua_pushinteger(L, rootfd);
+ 
	lua_setglobal(L, "rootfd");
+ 
	p = atf_utils_fork();
+ 
	if (p == 0) {
+ 
		if (luaL_dostring(L, "io.close(io.open(\"/plop\", \"w+\"))")) {
+ 
			printf("%s\n", lua_tostring(L, -1));
+ 
		}
+ 
		exit(lua_tonumber(L, -1));
+ 
	}
+ 
	atf_utils_wait(p, 0, "", "");
+ 
	atf_utils_file_exists("plop");
+
+ 
	p = atf_utils_fork();
+ 
	if (p == 0) {
+ 
		if (luaL_dostring(L, "os.rename(\"/plop\", \"/bob\")")) {
+ 
			printf("%s\n", lua_tostring(L, -1));
+ 
		}
+ 
		exit(lua_tonumber(L, -1));
+ 
	}
+ 
	atf_utils_wait(p, 0, "", "");
+ 
	atf_utils_file_exists("bob");
+
+ 
	p = atf_utils_fork();
+ 
	if (p == 0) {
+ 
		if (luaL_dostring(L, "os.remove(\"/bob\")\nassert(io.open(\"/bob\", \"r\"))")) {
+ 
			printf("%s\n", lua_tostring(L, -1));
+ 
		}
+ 
		exit(lua_tonumber(L, -1));
+ 
	}
+ 
	atf_utils_wait(p, 0, "[string \"os.remove(\"/bob\")...\"]:2: /bob: No such file or directory\n", "");
+ 
}
+
+ 
ATF_TC_BODY(fileops, tc)
+ 
{
+ 
	int rootfd = open(getcwd(NULL, 0), O_DIRECTORY);
+ 
	lua_State *L = luaL_newstate();
+ 
	luaL_openlibs(L);
+ 
	lua_pushinteger(L, rootfd);
+ 
	lua_setglobal(L, "rootfd");
+ 
	lua_override_ios(L, true);
+ 
	static const luaL_Reg test_lib[] = {
+ 
		{ "copy", lua_pkg_copy },
+ 
		{ "cmp", lua_pkg_filecmp},
+ 
		{ NULL, NULL },
+ 
	};
+ 
	luaL_newlib(L, test_lib);
+ 
	lua_setglobal(L, "test");
+ 
	pid_t p;
+
+ 
	FILE *f1 = fopen("test1", "w+");
+ 
	FILE *f2 = fopen("test2", "w+");
+ 
	FILE *f3 = fopen("test3", "w+");
+
+ 
	fputs("test", f1);
+ 
	fputs("test2", f2);
+ 
	fputs("test", f3);
+ 
	fclose(f1);
+ 
	fclose(f2);
+ 
	fclose(f3);
+
+ 
	p = atf_utils_fork();
+ 
	if (p == 0) {
+ 
		if (luaL_dostring(L, "test.cmp(1)")) {
+ 
			printf("%s\n", lua_tostring(L, -1));
+ 
		}
+ 
		exit(lua_tonumber(L, -1));
+ 
	}
+ 
	atf_utils_wait(p, 0, "[string \"test.cmp(1)\"]:1: bad argument #1 to 'cmp' (pkg.filecmp takes exactly two arguments)\n", "");
+
+ 
	p = atf_utils_fork();
+ 
	if (p == 0) {
+ 
		if (luaL_dostring(L, "test.cmp(1, 2, 3)")) {
+ 
			printf("%s\n", lua_tostring(L, -1));
+ 
		}
+ 
		exit(lua_tonumber(L, -1));
+ 
	}
+ 
	atf_utils_wait(p, 0, "[string \"test.cmp(1, 2, 3)\"]:1: bad argument #3 to 'cmp' (pkg.filecmp takes exactly two arguments)\n", "");
+
+ 
	p = atf_utils_fork();
+ 
	if (p == 0) {
+ 
		if (luaL_dostring(L, "return test.cmp(1, 2)")) {
+ 
			printf("%s\n", lua_tostring(L, -1));
+ 
		}
+ 
		exit(lua_tonumber(L, -1));
+ 
	}
+ 
	atf_utils_wait(p, 2, "", "");
+
+ 
	p = atf_utils_fork();
+ 
	if (p == 0) {
+ 
		if (luaL_dostring(L, "return test.cmp(\"test1\", 2)")) {
+ 
			printf("%s\n", lua_tostring(L, -1));
+ 
		}
+ 
		exit(lua_tonumber(L, -1));
+ 
	}
+ 
	atf_utils_wait(p, 2, "", "");
+
+ 
	p = atf_utils_fork();
+ 
	if (p == 0) {
+ 
		if (luaL_dostring(L, "return test.cmp(\"test1\", \"test2\")")) {
+ 
			printf("%s\n", lua_tostring(L, -1));
+ 
		}
+ 
		exit(lua_tonumber(L, -1));
+ 
	}
+ 
	atf_utils_wait(p, 1, "", "");
+
+ 
	p = atf_utils_fork();
+ 
	if (p == 0) {
+ 
		if (luaL_dostring(L, "return test.cmp(\"test1\", \"test3\")")) {
+ 
			printf("%s\n", lua_tostring(L, -1));
+ 
		}
+ 
		exit(lua_tonumber(L, -1));
+ 
	}
+ 
	atf_utils_wait(p, 0, "", "");
+
+ 
	p = atf_utils_fork();
+ 
	if (p == 0) {
+ 
		if (luaL_dostring(L, "return(test.copy(1, 2))")) {
+ 
			printf("%s\n", lua_tostring(L, -1));
+ 
		}
+ 
		exit(lua_tonumber(L, -1));
+ 
	}
+ 
	atf_utils_wait(p, 2, "", "");
+
+ 
	p = atf_utils_fork();
+ 
	if (p == 0) {
+ 
		if (luaL_dostring(L, "return(test.copy(\"test1\", \"nonexistent/2\"))")) {
+ 
			printf("%s\n", lua_tostring(L, -1));
+ 
		}
+ 
		exit(lua_tonumber(L, -1));
+ 
	}
+ 
	atf_utils_wait(p, 2, "", "");
+
+ 
	p = atf_utils_fork();
+ 
	if (p == 0) {
+ 
		if (luaL_dostring(L, "test.copy(\"test1\", \"test4\")\nreturn test.cmp(\"test1\", \"test4\")")) {
+ 
			printf("%s\n", lua_tostring(L, -1));
+ 
		}
+ 
		exit(lua_tonumber(L, -1));
+ 
	}
+ 
	atf_utils_wait(p, 0, "", "");
+ 
}
+
+ 
ATF_TC_BODY(prefix_path, tc)
+ 
{
+ 
	struct pkg *pkg = NULL;
+ 
	pkg_new(&pkg, PKG_INSTALLED);
+ 
	pkg_set(pkg, PKG_PREFIX, "/myprefix");
+ 
	lua_State *L = luaL_newstate();
+ 
	static const luaL_Reg test_lib[] = {
+ 
		{ "prefix_path", lua_prefix_path },
+ 
		{ NULL, NULL },
+ 
	};
+ 
	luaL_openlibs(L);
+ 
	lua_override_ios(L, false);
+ 
	luaL_newlib(L, test_lib);
+ 
	lua_setglobal(L, "test");
+ 
	lua_pushlightuserdata(L, pkg);
+ 
	lua_setglobal(L, "package");
+ 
	pid_t p;
+
+ 
	p = atf_utils_fork();
+ 
	if (p == 0) {
+ 
		if (luaL_dostring(L, "print(test.prefix_path())")) {
+ 
			printf("%s\n", lua_tostring(L, -1));
+ 
		}
+ 
		exit(lua_tonumber(L, -1));
+ 
	}
+ 
	atf_utils_wait(p, 0, "[string \"print(test.prefix_path())\"]:1: bad argument #0 to 'prefix_path' (pkg.prefix_path takes exactly one argument)\n", "");
+
+ 
	p = atf_utils_fork();
+ 
	if (p == 0) {
+ 
		if (luaL_dostring(L, "print(test.prefix_path(1, 2))")) {
+ 
			printf("%s\n", lua_tostring(L, -1));
+ 
		}
+ 
		exit(lua_tonumber(L, -1));
+ 
	}
+ 
	atf_utils_wait(p, 0, "[string \"print(test.prefix_path(1, 2))\"]:1: bad argument #2 to 'prefix_path' (pkg.prefix_path takes exactly one argument)\n", "");
+
+ 
	p = atf_utils_fork();
+ 
	if (p == 0) {
+ 
		if (luaL_dostring(L, "print(test.prefix_path(1))")) {
+ 
			printf("%s\n", lua_tostring(L, -1));
+ 
		}
+ 
		exit(lua_tonumber(L, -1));
+ 
	}
+ 
	atf_utils_wait(p, 0, "/myprefix/1\n", "");
+
+ 
	p = atf_utils_fork();
+ 
	if (p == 0) {
+ 
		if (luaL_dostring(L, "print(test.prefix_path(\"/1\"))")) {
+ 
			printf("%s\n", lua_tostring(L, -1));
+ 
		}
+ 
		exit(lua_tonumber(L, -1));
+ 
	}
+ 
	atf_utils_wait(p, 0, "/1\n", "");

}



ATF_TP_ADD_TCS(tp)

{

	ATF_TP_ADD_TC(tp, readdir);
+ 
	ATF_TP_ADD_TC(tp, stat);
+ 
	ATF_TP_ADD_TC(tp, print_msg);
+ 
	ATF_TP_ADD_TC(tp, execute);
+ 
	ATF_TP_ADD_TC(tp, override);
+ 
	ATF_TP_ADD_TC(tp, fileops);
+ 
	ATF_TP_ADD_TC(tp, prefix_path);



	return (atf_no_error());

}