1e4e135 Use break to exit loop instead of goto cleanup — HardenedBSD-pkg

rad:z3QDZAW2FAfuLvihrhiyDC9fAD8G9

HardenedBSD Package Manager

Use break to exit loop instead of goto cleanup

Stefan Eßer committed 4 years ago

commit 1e4e1351a6ca11c88c75a79e2b0177f98edd783a
parent 1cec8b5

1 file changed +1 -2

modified src/query.c

@@ -1007,7 +1007,7 @@ exec_query(int argc, char **argv)

 		if ((it = pkgdb_query_cond(db, condition_sql, pkgname, match)) == NULL) {
 			warnx("DEBUG: %s/%s\n", condition_sql ? condition_sql : "-", pkgname ? pkgname : "-");
 			retcode = EXIT_FAILURE;
 			goto cleanup;
 			break;
 		}
 		while ((ret = pkgdb_it_next(it, &pkg, query_flags)) == EPKG_OK) {

@@ -1030,7 +1030,6 @@ exec_query(int argc, char **argv)

 		retcode = EXIT_FAILURE;
 	}
 cleanup:
 	pkg_free(pkg);
 	pkgdb_release_lock(db, PKGDB_LOCK_READONLY);