Radish alpha
r
rad:z39mP9rQAaGmERfUMPULfPUi473tY
Radicle terminal user interface
Radicle
Git
Implement `patch review`
Merged did:key:z6MkgFq6...nBGz opened 1 year ago

This adds a new interface for reviewing patch revisions (). It starts a new or resumes an existing review and provides an UX to add comments, accept hunks or reject them.

Reviews need to be finalized via rad patch review [--accept | --reject] <id>.

Known issues / future improvements

  • startup is slow on large patches: highlighting is expensive and needs to be done asynchronously
  • single hunks can’t be rejected once they were accepted: current UX is to discard all that were already accepted and start out new
  • existing comments will not be shown when adding new ones in the editor
did:key:z6MkgFq6...nBGz opened with revision d786b03b on base d819a2e8 +3251 -84 1 year ago

This adds a new interface for reviewing patch revisions (). It starts a new or resumes an existing review and provides an UX to add comments, accept hunks or reject them.

Reviews need to be finalized via rad patch review [--accept | --reject] <id>.

Known issues / future improvements

  • startup is slow on large patches: highlighting is expensive and needs to be done asynchronously
  • single hunks can’t be rejected once they were accepted: current UX is to discard all that were already accepted and start out new
  • existing comments will not be shown when adding new ones in the editor
did:key:z6MkgFq6...nBGz merged revision d786b03b at 35850c02 1 year ago