Radish alpha
r
rad:z39mP9rQAaGmERfUMPULfPUi473tY
Radicle terminal user interface
Radicle
Git
Testsuite depends on build
Closed { reason: Solved } did:key:z6MkwcUR...q1kL opened 8 months ago

The testsuite depends on a successfully built binary.

If you execute cargo test (or FWIW cargo nextest r) from a fresh clone of the repository, the testsuite really should not fail. This drives away possible contributors (“Look, their master branch does not even build successfully”).

I see the value in the tests that execute the binary and check whether commands are properly forwarded and so on (not so much in whether –help outputs the correct help text actually).

But maybe we can find a better way?

z6MkgFq6...nBGz commented 8 months ago

Since I anticipated complains about this already, it does not come as a surprise ;) For the time being, I disabled all CLI tests such that cargo test does not fail anymore.

Those tests should be rewritten, such that they do not need the binary, but rather test the command modules directly. Will keep this open to track progress on that.

z6MkgFq6...nBGz commented 8 months ago

All CLI tests have been rewritten such that they don’t rely on the binary anymore.