Radish alpha
r
radicle-tui
rad:z39mP9rQAaGmERfUMPULfPUi473tY
Radicle terminal user interface
Radicle
Git
Commits › 8772445
bin/issue: Replace manual filter-collect
Matthias Beyer committed 4 months ago
commit 87724450835159c1f9314f21036c92c25f896549
parent 31dd223
1 file changed +17 -15
modified bin/commands/issue/list.rs
@@ -189,25 +189,27 @@ impl TryFrom<(&Context, &TerminalInfo)> for State {
        };



        // Convert into UI items
- 
        let mut items = vec![];
- 
        for issue in issues {
- 
            if let Ok(item) = IssueItem::new(&context.profile, issue.clone()) {
- 
                items.push(item);
- 
            }
- 
        }
+ 
        let mut items: Vec<_> = issues
+ 
            .into_iter()
+ 
            .flat_map(|issue| IssueItem::new(&context.profile, issue).ok())
+ 
            .collect();
+ 


        items.sort_by(|a, b| b.timestamp.cmp(&a.timestamp));



        // Pre-select first comment
- 
        let mut selected_comments = HashMap::new();
- 
        for item in &items {
- 
            selected_comments.insert(
- 
                item.id,
- 
                item.root_comments()
+ 
        let selected_comments: HashMap<_, _> = items
+ 
            .iter()
+ 
            .map(|item| {
+ 
                let id = item.id;
+ 
                let comm = item
+ 
                    .root_comments()

                    .first()
- 
                    .map(|comment| vec![comment.id])
- 
                    .unwrap_or_default(),
- 
            );
- 
        }
+ 
                    .map(|c| vec![c.id])
+ 
                    .unwrap_or_default();
+
+ 
                (id, comm)
+ 
            })
+ 
            .collect();



        Ok(Self {

            mode: context.mode.clone(),