Radish alpha
r
rad:z2UcCU1LgMshWvXj6hXSDDrwB8q8M
Radicle Job Collaborative Object
Radicle
Git
feat: add an action to set the log of a run to another URL
Open levitte opened 1 month ago

This allows storing the log as a commit in a repository, and referring to that commit by commit id.

This also allows starting with a live / interactive log while the run is running, and change that to a stored log when the run is done.

levitte opened with revision a8ec6d69 on base 8799f728 +37 -15 1 month ago

This allows storing the log as a commit in a repository, and referring to that commit by commit id.

This also allows starting with a live / interactive log while the run is running, and change that to a stored log when the run is done.

liw reviewed · 1 comment 1 month ago

Is this a breaking change? The commit message should be explicit about that.

I would actually prefer to separate the setting of URL into its own action, distinct from setting success or failure.

levitte pushed revision 2 8723ba80 on base 8799f728 +88 -3 1 month ago

This allows storing the log as a commit in a repository when finishing a run, and referring to that commit by commit id.

This also allows starting with a live / interactive log while the run is running, and change that to a stored log when the run is done.

The CLI commands rad-job succeeded and rad-job failed are modified to allow an optional third URL command line argument.

levitte pushed revision 3 b210f23e on base 8799f728 +81 -3 1 month ago

Updates to appease the actions in .radicle/ambient.yaml

fintohaps pushed revision 4 f180fc74 on base 8799f728 +82 -3 1 month ago

REVIEW

See commits.

Can we also add a CHANGELOG entry? Note that this backwards-compatible, but not forwards compatible, so it is a breaking change for clients that see the new Action.

levitte pushed revision 5 235b7fa0 on base 8799f728 +82 -3 1 month ago

Integrated @fintohaps’ review commits

levitte pushed revision 6 4596fdd6 on base 8799f728 +81 -3 14 days ago

Use a real URI in tests