feat: add an action to set the log of a run to another URL — radicle-job

Radicle Job Collaborative Object

feat: add an action to set the log of a run to another URL

✓ 2/2 checks passed levitte wants to merge 1 commit into main · opened 2 months ago

This allows storing the log as a commit in a repository, and referring to that commit by commit id.

This also allows starting with a live / interactive log while the run is running, and change that to a stored log when the run is done.

✓ All checks passed — 2 passed View logs ↗

Activity Commits 1 Changes +81 -3

levitte opened with revision a8ec6d69e668c81ad502f189fcf02cd1904e1b90 on base 8799f728bc1b2e8d1824d2e06557059f8c82127d +37 -15 2 months ago

liw reviewed · 1 comment 2 months ago

Is this a breaking change? The commit message should be explicit about that.

I would actually prefer to separate the setting of URL into its own action, distinct from setting success or failure.

levitte pushed revision 2 8723ba80d9f2027d46c24c5ad3f9cf739d26f7ab on base 8799f728bc1b2e8d1824d2e06557059f8c82127d +88 -3 2 months ago

This allows storing the log as a commit in a repository when finishing a run, and referring to that commit by commit id.

This also allows starting with a live / interactive log while the run is running, and change that to a stored log when the run is done.

The CLI commands rad-job succeeded and rad-job failed are modified to allow an optional third URL command line argument.

levitte pushed revision 3 b210f23e7b066d027586595384692701264c8fce on base 8799f728bc1b2e8d1824d2e06557059f8c82127d +81 -3 2 months ago

Updates to appease the actions in .radicle/ambient.yaml

did:key:z6MkireR...3voM pushed revision 4 f180fc74052918eacd11b0872f080955959c5275 on base 8799f728bc1b2e8d1824d2e06557059f8c82127d +82 -3 2 months ago

REVIEW

See commits.

Can we also add a CHANGELOG entry? Note that this backwards-compatible, but not forwards compatible, so it is a breaking change for clients that see the new Action.

levitte pushed revision 5 235b7fa0db2d867206079de6f77c485bb64f5d0b on base 8799f728bc1b2e8d1824d2e06557059f8c82127d +82 -3 2 months ago

Integrated @fintohaps' review commits

levitte pushed revision 6 4596fdd6c4c572b31a143a358ce0274fca71e382 on base 8799f728bc1b2e8d1824d2e06557059f8c82127d +81 -3 1 month ago

Use a real URI in tests